arch/arm/src/samv7: enable GPIO clock even if interrupt not enabled#16079
Merged
lupyuen merged 1 commit intoapache:masterfrom Mar 29, 2025
Merged
arch/arm/src/samv7: enable GPIO clock even if interrupt not enabled#16079lupyuen merged 1 commit intoapache:masterfrom
lupyuen merged 1 commit intoapache:masterfrom
Conversation
GPIO peripheral clocks have to be enabled even if interrupt support on the peripheral is not enabled, otherwise GPIO input will not work. This is probably caused by input filters that need clock signal. This commit moves the clock enable call from interrupt specific function to common initialization function that is called from _start entry point function. Signed-off-by: Michal Lenc <michallenc@seznam.cz>
|
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, although it could be slightly improved. Here's a breakdown: Strengths:
Areas for Improvement (Minor):
Example of improved "Impact" section: Example of improved "Testing" section: GPIOD pin X read: -1 (or some error indicating failure) GPIOD pin X read: 1 By addressing these minor points, the PR would be even stronger and easier to review. |
xiaoxiang781216
approved these changes
Mar 26, 2025
lupyuen
approved these changes
Mar 28, 2025
jerpelea
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GPIO peripheral clocks have to be enabled even if interrupt support on the peripheral is not enabled, otherwise GPIO input will not work. This is probably caused by input filters that need clock signal.
This commit moves the clock enable call from interrupt specific function to common initialization function that is called from
_startentry point function.Impact
GPIO inputs now work even if the peripheral is not configured with interrupt support (option
CONFIG_SAMV7_GPIOx_IRQ).Testing
Tested on custom SAMv7 board with GPIOD peripheral. Reading pins now work even if
CONFIG_SAMV7_GPIOD_IRQis disabled.